Add ScalarType 22 BITS16 support in etdump gen and deserialization
#6504
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6504
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit be12417 with merge base 6b01b91 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Oct 25, 2024
…ytorch#6504) Summary: Add support in etdump gen and etdump parsing for ScalarType 22 `BITS16`. Here's where the type is defined: https://www.internalfb.com/code/fbsource/[64a8013e3ebfbbaa70c220fc90102683d3181ad8]/fbcode/executorch/runtime/core/portable_type/scalar_type.h?lines=85 Note: `fbcode/executorch/schema/scalar_type.fbs` and `fbcode/executorch/devtools/etdump/scalar_type.fbs` are copies of each other to get around some build issue and there's a script to make sure they're in sync. Differential Revision: D64812253
Olivia-liu
force-pushed
the
export-D64812253
branch
from
4eb0602 to
8493773
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
Olivia-liu
force-pushed
the
export-D64812253
branch
from
8493773 to
9dc0412
Compare
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Oct 28, 2024
…ytorch#6504) Summary: Add support in etdump gen and etdump parsing for ScalarType 22 `BITS16`. Here's where the type is defined: https://www.internalfb.com/code/fbsource/[64a8013e3ebfbbaa70c220fc90102683d3181ad8]/fbcode/executorch/runtime/core/portable_type/scalar_type.h?lines=85 Note: `fbcode/executorch/schema/scalar_type.fbs` and `fbcode/executorch/devtools/etdump/scalar_type.fbs` are copies of each other to get around some build issue and there's a script to make sure they're in sync. Reviewed By: Gasoonjia Differential Revision: D64812253
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Oct 28, 2024
…ytorch#6504) Summary: Add support in etdump gen and etdump parsing for ScalarType 22 `BITS16`. Here's where the type is defined: https://www.internalfb.com/code/fbsource/[64a8013e3ebfbbaa70c220fc90102683d3181ad8]/fbcode/executorch/runtime/core/portable_type/scalar_type.h?lines=85 Note: `fbcode/executorch/schema/scalar_type.fbs` and `fbcode/executorch/devtools/etdump/scalar_type.fbs` are copies of each other to get around some build issue and there's a script to make sure they're in sync. Reviewed By: Gasoonjia Differential Revision: D64812253
Olivia-liu
force-pushed
the
export-D64812253
branch
from
9dc0412 to
197f7de
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
larryliu0820
approved these changes
Oct 28, 2024
Olivia-liu
added a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Oct 28, 2024
…ytorch#6504) Summary: Add support in etdump gen and etdump parsing for ScalarType 22 `BITS16`. Here's where the type is defined: https://www.internalfb.com/code/fbsource/[64a8013e3ebfbbaa70c220fc90102683d3181ad8]/fbcode/executorch/runtime/core/portable_type/scalar_type.h?lines=85 Note: `fbcode/executorch/schema/scalar_type.fbs`, `fbcode/executorch/devtools/etdump/scalar_type.fbs` and `fbcode/executorch/devtools/bundled_program/schema/scalar_type.fbs` are copies of each other to get around some build issue and there's a script to make sure they're in sync. Reviewed By: larryliu0820, Gasoonjia Differential Revision: D64812253
Olivia-liu
force-pushed
the
export-D64812253
branch
from
197f7de to
97d3c60
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
…ytorch#6504) Summary: Add support in etdump gen and etdump parsing for ScalarType 22 `BITS16`. Here's where the type is defined: https://www.internalfb.com/code/fbsource/[64a8013e3ebfbbaa70c220fc90102683d3181ad8]/fbcode/executorch/runtime/core/portable_type/scalar_type.h?lines=85 Note: `fbcode/executorch/schema/scalar_type.fbs`, `fbcode/executorch/devtools/etdump/scalar_type.fbs` and `fbcode/executorch/devtools/bundled_program/schema/scalar_type.fbs` are copies of each other to get around some build issue and there's a script to make sure they're in sync. Reviewed By: larryliu0820, Gasoonjia Differential Revision: D64812253
Olivia-liu
force-pushed
the
export-D64812253
branch
from
97d3c60 to
be12417
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D64812253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add support in etdump gen and etdump parsing for ScalarType 22
BITS16.Note: fbcode/executorch/schema/scalar_type.fbs and fbcode/executorch/devtools/etdump/scalar_type.fbs are copies of each other for historical reasons.
Differential Revision: D64812253